Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add avgRTT to nfs mountstats" #624

Closed
wants to merge 1 commit into from
Closed

Revert "add avgRTT to nfs mountstats" #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions mountstats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ type NFSOperationStats struct {
CumulativeTotalResponseMilliseconds uint64
// Duration from when a request was enqueued to when it was completely handled.
CumulativeTotalRequestMilliseconds uint64
// The average time from the point the client sends RPC requests until it receives the response.
AverageRTTMilliseconds float64
// The count of operations that complete with tk_status < 0. These statuses usually indicate error conditions.
Errors uint64
}
Expand Down Expand Up @@ -571,6 +569,7 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {

ns = append(ns, n)
}

opStats := NFSOperationStats{
Operation: strings.TrimSuffix(ss[0], ":"),
Requests: ns[0],
Expand All @@ -582,9 +581,6 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {
CumulativeTotalResponseMilliseconds: ns[6],
CumulativeTotalRequestMilliseconds: ns[7],
}
if ns[0] != 0 {
opStats.AverageRTTMilliseconds = float64(ns[6]) / float64(ns[0])
}

if len(ns) > 8 {
opStats.Errors = ns[8]
Expand Down
2 changes: 0 additions & 2 deletions mountstats_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@
CumulativeQueueMilliseconds: 6,
CumulativeTotalResponseMilliseconds: 79386,
CumulativeTotalRequestMilliseconds: 79407,
AverageRTTMilliseconds: 61.16024653312789,
},
{
Operation: "WRITE",
Expand All @@ -353,7 +352,6 @@
CumulativeQueueMilliseconds: 18446743919241604546,
CumulativeTotalResponseMilliseconds: 1667369447,
CumulativeTotalRequestMilliseconds: 1953587717,
AverageRTTMilliseconds: 0.5695744656983355,
},
},
Transport: NFSTransportStats{
Expand Down Expand Up @@ -427,7 +425,7 @@
CumulativeQueueMilliseconds: 320,
CumulativeTotalResponseMilliseconds: 11,
CumulativeTotalRequestMilliseconds: 331,
AverageRTTMilliseconds: 0.6875,

Check failure on line 428 in mountstats_test.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field AverageRTTMilliseconds in struct literal of type struct{Operation string; Requests uint64; Transmissions uint64; MajorTimeouts uint64; BytesSent uint64; BytesReceived uint64; CumulativeQueueMilliseconds uint64; CumulativeTotalResponseMilliseconds uint64; CumulativeTotalRequestMilliseconds uint64; Errors uint64} (typecheck)

Check failure on line 428 in mountstats_test.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field AverageRTTMilliseconds in struct literal of type struct{Operation string; Requests uint64; Transmissions uint64; MajorTimeouts uint64; BytesSent uint64; BytesReceived uint64; CumulativeQueueMilliseconds uint64; CumulativeTotalResponseMilliseconds uint64; CumulativeTotalRequestMilliseconds uint64; Errors uint64} (typecheck)
Errors: 0,
},
},
Expand Down
Loading