feat(blockdevice): added sysblockdevicesize method and test #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add edit: i believe i did this in 8dc60f1 |
dswarbrick
reviewed
Jul 5, 2024
blockdevice/stats.go
Outdated
| if err != nil { | ||
| return 0, err | ||
| } | ||
| return 512 * size, nil |
There was a problem hiding this comment.
Let's make this a const SectorSize
|
just following up on this cc @discordianfish |
or cc @SuperQ |
|
hey could I get a review on this please? any idea who might be best to take a look @dswarbrick |
|
@fs185143 You'll have better luck attracting the attention of maintainers if all CI tests are green, plus all commits need to be signed off to comply with the DCO. |
fs185143
force-pushed
the
blockdevice-size
branch
from
c5589cf to
b0b6389
Compare
|
closing in favour of #658 (fixed issues like DCO) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In part to support prometheus/node_exporter#3068, I have added a new method that retrieves the value of
/sys/block/<device>/size