Feature/stream start, finish #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrillicw
changed the base branch from
drive-closure-transaction
to
feature/ReplicatorOffboarding
ynewmann
reviewed
Oct 25, 2021
| @@ -170,4 +170,5 @@ const ( | |||
| ByteSize VarSize = 1 | |||
| ShortSize VarSize = 2 | |||
| IntSize VarSize = 4 | |||
| LongSize VarSize = 8 | |||
There was a problem hiding this comment.
usually, we use an array of IntSize for uint64/int64
sdk/streamingv2_schema.go
Outdated
| newArrayAttribute("maxFee", IntSize), | ||
| newArrayAttribute("deadline", IntSize), | ||
| newArrayAttribute("driveKey", ByteSize), | ||
| newScalarAttribute("expectedUploadSize", LongSize), |
There was a problem hiding this comment.
look at other uint64 fields (maxFee, deadline, etc). They use IntSize array for it. So:
newArrayAttribute("expectedUploadSize", IntSize)
sdk/streamingv2_transaction.go
Outdated
| } | ||
|
|
||
| func (tx *StreamStartTransaction) String() string { | ||
| return "" |
There was a problem hiding this comment.
forgotten implementation?
| maxFee: [uint]; | ||
| deadline: [uint]; | ||
| driveKey: [ubyte]; | ||
| expectedUploadSize: uint64; |
There was a problem hiding this comment.
ulong. But let follow other transaction and use [uint].:D
ynewmann
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.