Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update websocket client connection flow #52

Closed
wants to merge 3 commits into from
Closed

Update websocket client connection flow #52

wants to merge 3 commits into from

Conversation

vadimdidenkogs
Copy link
Contributor

@vadimdidenkogs vadimdidenkogs commented Sep 27, 2019 •
edited
Loading

Fix race conditions for websocket connection/disconnect Client

Wondertan
Wondertan suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task was to fix the bugs and races. For example race #34 is still possible

@Wondertan
Copy link
Contributor

Wondertan commented Sep 30, 2019 •
edited
Loading

Also, pls mention in PR what issues you fixed

@vadimdidenkogs vadimdidenkogs added the bug Something isn't working label Oct 18, 2019
@vadimdidenkogs
Copy link
Contributor Author

The task was to fix the bugs and races. For example race #34 is still possible

We fix #34 in the #54 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx Awaiting requested review from xgreenx

@Wondertan Wondertan Awaiting requested review from Wondertan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadimdidenkogs @Wondertan