Accurate floating point comparisons with fpCompare #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Solymos <[email protected]>
Signed-off-by: Peter Solymos <[email protected]>
Signed-off-by: Peter Solymos <[email protected]>
Signed-off-by: Peter Solymos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will break past behaviour, but the default makes more sense, i.e. more accurate when dealing with numeric vectors. In every other cases, the new behaviour is identical to previous behaviour. Users can switch back using new options, but I don't see a reason what that could be a good idea other than for reproducibility reasons.
This PR closes #17