feat: added prev_owner to response log

[edison0xyz]

Resolves #11

Useful feature and have added it in.

[JakeHartnell]

Almost like @larry0x's comment of using from and to like the Ethereum transfer events.

It is important to maintain sender, as that may be different than the owner, even though there is a little duplication there.

[JakeHartnell]

TransferNFT needs to be consistent with SendNFT.

[JakeHartnell]

What do folks think about using to over recipient? Mirroring Ethereum: https://ethereum.org/en/developers/docs/standards/tokens/erc-721/#events

[the-frey]

FWIW I'm in favour of sticking close to the ETH standards where possible. from and to are probably the way to go in that case IIUC.

[iLoveBusinessDevelopment]

I think we should continue with recipient. CW20 is already widely used at this point and uses recipient.

[the-frey]

Hmmm, I suppose I'm looking at the POV of devs who are coming from ETH/ERC721 land. Although can see the argument for CW20 style too 🤷

[edison0xyz]

I think that we might be better to stick with the current CW standards.
Though i see the point of standardising with the Ethereum contracts, but there should be consistency amongst the CosmWasm contracts.

Changing everything to Ethereum sounds like a lot of work in code-change and communication with exisiting protocols. So perhaps let's avoid that.

[orkunkl]

LGTM

[ALPAC-4]

And I think we need to add owner at mint response log

https://github.com/CosmWasm/cw-nfts/blob/2712c05fbc365a44809c904f8508410c4f70383e/contracts/cw721-base/src/execute.rs#L111

I think owner is more important information than minter. Minter is always same for same contract

[shanev]

This issue is a bit stale. Okay to close?

[JakeHartnell]

This issue is a bit stale. Okay to close?

Yeah.

[peara]

@JakeHartnell @larry0x @shanev Please reconsider this PR. This is very useful for indexers and apps and for the consistency of cw721 as well.
I think adding owner as already implemented is good enough. The only issue remaining is adding the same to send_nft and mint, is that right?