Skip to content

Commit

Permalink
fix typo in pubnub.yaml and bump php in test matrix
Browse files Browse the repository at this point in the history
  • Loading branch information
seba-aln committed Oct 21, 2024
1 parent c26672d commit de0b4dd
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
max-parallel: 1
fail-fast: true
matrix:
php: [8.0, 8.1, 8.2]
php: [8,1, 8.2, 8.3]
env:
PUBLISH_KEY: ${{ secrets.SDK_PUB_KEY }}
SUBSCRIBE_KEY: ${{ secrets.SDK_SUB_KEY }}
Expand Down
6 changes: 3 additions & 3 deletions .pubnub.yml
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ sdks:
minimum-os-version:
- Mac OS X 10.8
maximum-os-version:
- macOS 15
- macOS 15.0.1
target-architecture:
- arm64
- x86-64
Expand Down Expand Up @@ -387,7 +387,7 @@ sdks:
minimum-os-version:
- Mac OS X 10.8
maximum-os-version:
- macOS 15
- macOS 15.0.1
target-architecture:
- arm64
- x86-64
Expand Down Expand Up @@ -449,7 +449,7 @@ sdks:
minimum-os-version:
- Mac OS X 10.8
maximum-os-version:
- macOS 15
- macOS 15.0.1
target-architecture:
- arm64
- x86-64
Expand Down
1 change: 0 additions & 1 deletion examples/GrantToken.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
print("Token TTL: $tokensTTL\n");
print("Token My Channel Read: " . (int)$tokensMyChannelRead . "\n");
print("Token My Channel Write: " . (int)$tokensMyChannelWrite . "\n");

} catch (\PubNub\Exceptions\PubNubServerException $e) {
var_dump($e->getBody());
}
6 changes: 2 additions & 4 deletions src/PubNub/Endpoints/Access/GrantToken.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace PubNub\Endpoints\Access;


use PubNub\Endpoints\Endpoint;
use PubNub\Exceptions\PubNubValidationException;
use PubNub\PubNubUtil;
Expand All @@ -12,7 +11,6 @@
use PubNub\Models\Consumer\AccessManager\PNAccessManagerTokenResult;
use PubNub\PubNubCborDecode;


class GrantToken extends Endpoint
{
protected const PATH = '/v3/pam/%s/grant';
Expand Down Expand Up @@ -240,7 +238,7 @@ public function buildPath()
/**
* @return string
*/
public function sync() : string
public function sync(): string
{
return parent::sync();
}
Expand All @@ -249,7 +247,7 @@ public function sync() : string
* @param string $token
* @return string
*/
public function createResponse($response) : string
public function createResponse($response): string
{
return $response['data']['token'];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace PubNub\Models\Consumer\FileSharing;


class PNGetFileDownloadURLResult
{
protected string $fileUrl;
Expand Down

0 comments on commit de0b4dd

Please sign in to comment.