Feat/support custom message type #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seba-aln
force-pushed
the
feat/support-custom-message-type
branch
from
010ef6f
to
a6a5c0b
Compare
seba-aln
force-pushed
the
feat/support-custom-message-type
branch
from
a6a5c0b
to
957552a
Compare
seba-aln
force-pushed
the
feat/support-custom-message-type
branch
from
422ae5c
to
2ffb7cd
Compare
seba-aln
force-pushed
the
feat/support-custom-message-type
branch
from
2ffb7cd
to
0d90f33
Compare
marcin-cebo
reviewed
Nov 18, 2024
| @@ -15,24 +15,30 @@ | |||
| $pnConfig = new PNConfiguration(); | |||
| $pnConfig->setPublishKey(getenv('PN_KEY_PUBLISH')); | |||
There was a problem hiding this comment.
if PN_KEY_PUBLISH or PN_KEY_SUBSCRIBE is not set, the script might fail without a clear error message ?
There was a problem hiding this comment.
this is just a code example to be analyzed and not a demo :)
| @@ -31,8 +31,9 @@ class FetchMessages extends Endpoint | |||
|
|
|||
| protected bool $includeMeta = false; | |||
| protected bool $includeUuid = false; | |||
| protected bool $includeMessageType = false; | |||
| protected bool $includeMessageType = true; | |||
There was a problem hiding this comment.
Why you changed default from false to true ?
There was a problem hiding this comment.
to be in line with tomato. with the field set otherwise tomato failed all the time so I thought it's the proper value
tests/Acceptance/CustomMessageType/history-custom-mssg-type.feature
Outdated
Show resolved
Hide resolved
marcin-cebo
approved these changes
Nov 19, 2024
seba-aln
force-pushed
the
feat/support-custom-message-type
branch
2 times, most recently
from
c1af17f
to
29c7cf8
Compare
seba-aln
force-pushed
the
feat/support-custom-message-type
branch
from
29c7cf8
to
e5c5462
Compare
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
techwritermat
approved these changes
Nov 20, 2024
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add custom message type support for selected APIs
Add custom message type support for the following APIs - publish, signal, share file, subscribe and history