Fix deprecation warnings #811
Conversation
| - name: Install requirements | ||
| run: pip3 install github | ||
| - name: Check commit message | ||
| {{ install_python_deps(["requests", "pygithub"]) | indent(6) }} |
There was a problem hiding this comment.
We install missing packages in the scripts themselves; the question is, do we need this^?
There was a problem hiding this comment.
I thought i removed that.
| @@ -74,7 +73,7 @@ jobs: | |||
|
|
|||
| {{ setup_python() | indent(6) }} | |||
|
|
|||
| {{ install_python_deps("requests") | indent(6) }} | |||
| {{ install_python_deps(["requests"]) | indent(6) }} | |||
There was a problem hiding this comment.
I would also install this requirement inside the caller ".github/workflows/scripts/publish_docs.sh". Do you think it is worth it to revisit all installing dependencies and move them to one place?
There was a problem hiding this comment.
I intended to stop installing anything from scripts, because i consider that to be dangerous if you try to run any of these locally.
There was a problem hiding this comment.
Gotcha, then it makes sense to remove pip calls from the scripts, in another PR.
There was a problem hiding this comment.
And i dind't even check with "git grep" ... XD
| {%- if test_lowerbounds %} | ||
| echo "{{ "${{ needs.test.outputs.deprecations-lowerbounds }}" }}" | base64 -d | ||
| {%- endif %} | ||
| cat deprecations-*.txt | sort -u |
There was a problem hiding this comment.
Do we miss "{{ plugin_name }}" in the path?
There was a problem hiding this comment.
At this point no. As we do no checkout, we don't have the directory "{{ plugin_name }}" to do that. Do you think we should create it for consistency?
Consolidate some macros. Add a lot of quoting because explicit is better than implicit. [noissue]
mdellweg
force-pushed
the
fix_deprecation_warnings
branch
from
5b6d75a to
146b9c8
Compare
mdellweg
force-pushed
the
fix_deprecation_warnings
branch
from
720f438 to
5f9c44b
Compare
This will not rely on job outputs, but instead use a workflow artifact. [noissue]
[noissue]
mdellweg
force-pushed
the
fix_deprecation_warnings
branch
from
5f9c44b to
b7dd772
Compare
This is yet another legacy of the pulp_file merge.