[PULP-206] Refactor nightly #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
refactor_nightly
branch
from
ed780bb to
5f19e54
Compare
pedro-psb
reviewed
Nov 27, 2024
|
|
||
| {{ display_logs() | indent(6) }} | ||
| {%- endif %} | ||
| ... |
There was a problem hiding this comment.
This is being polite in yaml.
There was a problem hiding this comment.
I'm also on a crusade quote all string values.
There was a problem hiding this comment.
I'm following the quote crusade, but i was not aware of the ... thing.
There was a problem hiding this comment.
Oh yeah, its usually used in multifile yaml. I remembered it as was just ---.
pedro-psb
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is the actual fix.
The second commit is to make sure it does not happen again.