Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulp-cli-deb missing pulpexport capability #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjmullicani
Copy link

Closes #40

@tjmullicani tjmullicani changed the title Pulpcore export fix Fix pulp-cli-deb missing pulpexport capability Dec 1, 2022
@lubosmj
Copy link
Member

lubosmj commented Jan 4, 2023

Can this PR be accepted by someone from @pulp/debian?

@quba42
Copy link
Collaborator

quba42 commented Jan 5, 2023

I have not been so involved with the import/export feature, and I know we are still struggling to get this feature working within Katello (the only place were the plugin maintainers actively use it): https://community.theforeman.org/t/support-importing-content-views-with-deb-content-with-hammer-content-import/31178

As a result I am unsure how well the feature works on the Pulp side, and if it is wise to make it easier to use via pulp CLI.

@hstct @mdellweg @Manisha15 Do you have any opinions on how best to continue? (Any of you have time to test this?)

@Manisha15
Copy link

I have not been so involved with the import/export feature, and I know we are still struggling to get this feature working within Katello (the only place were the plugin maintainers actively use it): https://community.theforeman.org/t/support-importing-content-views-with-deb-content-with-hammer-content-import/31178

As a result I am unsure how well the feature works on the Pulp side, and if it is wise to make it easier to use via pulp CLI.

@hstct @mdellweg @Manisha15 Do you have any opinions on how best to continue? (Any of you have time to test this?)

I have tested it on pulp side and it worked fine and the PR is also merged on pulp side. I can test it using via pulp CLI as it can also verify if it working on pulp side properly or not and if the issue is only on Katello side or on pulp side as well.

@quba42
Copy link
Collaborator

quba42 commented Jan 5, 2023

@Manisha15 If you can review this PR (test the feature using pulp-cli with these changes), then I am happy to merge this.

It also looks like this does not need a test other than the ones already in place for the pulpcore feature. (None of the other content plugins have their own separate tests for import/export)

@tjmullicani tjmullicani force-pushed the pulpcore_export_fix branch from 4aa050c to cba91ef Compare March 9, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing pulpexport capability
5 participants