[PULP-215] Core version dependence #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
changed the title
mdellweg
force-pushed
the
pulpcore_versions
branch
4 times, most recently
from
f7d0d66 to
30d918a
Compare
mdellweg
force-pushed
the
pulpcore_versions
branch
from
30d918a to
c389a01
Compare
mdellweg
changed the title
mdellweg
force-pushed
the
pulpcore_versions
branch
from
c389a01 to
4b98ddc
Compare
gerrod3
reviewed
Dec 3, 2024
gen-client.sh
Outdated
|
|
||
| if language.lower() == "python": | ||
| if core_version >= Version("3.70.dev"): | ||
| print("v4.3.1") |
There was a problem hiding this comment.
Do you plan to update the generator to a higher version or wait until the next breaking change?
There was a problem hiding this comment.
Oh, I planned to add this if only when we really update the image...
Add the infrastructure so we can select the generator image based on the combination of the target language and the pulpcore version. The template replacements are versioned accordingly. [noissue]
mdellweg
force-pushed
the
pulpcore_versions
branch
from
4b98ddc to
5e194fc
Compare
gerrod3
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.