Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new fixture signing key #1424

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Use new fixture signing key #1424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pulp_container/tests/functional/api/test_push_signatures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ def test_assert_signed_image(
decrypted = gpg.decrypt(raw_s)

assert decrypted.key_id == keyid
assert decrypted.fingerprint == fingerprint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fingerprint comes from the bindings. I believe that should be fine. Maybe I'm missing something again.

Copy link
Contributor Author

@dralley dralley Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment, fingerprint and keyid are effectively the same, as one (I believe keyid) is just the last X bits of the other. Realistically just checking one is the same as checking both as they are both meant to be functionally unique values.

Edit: at least for the purposes of this test. Supposedly both fingerprints and particularly keyids are attackable by brute force, but that's a bit beyond the scope of what we're testing.

assert decrypted.status == "signature valid"
assert decrypted.username == "Pulp QE"

json_s = json.loads(decrypted.data)

Expand Down
Loading