Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak delta manifests support #1516

Closed
wants to merge 1 commit into from

Conversation

MichalPysik
Copy link
Member

@MichalPysik MichalPysik commented Feb 15, 2024

Added Flatpak deltas to the defaultly supported OCI media types.

closes #1495

CHANGES/1495.feature Outdated Show resolved Hide resolved
@@ -45,6 +45,10 @@
"application/vnd.wasm.config.v1+json": [
"application/vnd.wasm.content.layer.v1+wasm",
],
# delta manifest
"application/vnd.redhat.delta.config.v1+json": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs say that manifest should be of special delta type as well, this would be great to clarify with the authors, and if confirmed then this would require us to add it to the DB manifests media type choices, and update the json schema validator

@MichalPysik MichalPysik changed the title Delta manifests support Flatpak delta manifests support Feb 19, 2024
Added Flatpak deltas to the defaultly supported OCI media types.

closes pulp#1495
@lubosmj lubosmj marked this pull request as draft February 28, 2024 11:34
@lubosmj
Copy link
Member

lubosmj commented Mar 5, 2024

This might collide with #1533. We are leaving this in draft for now until the referenced PR gets merged.

@lubosmj
Copy link
Member

lubosmj commented Mar 8, 2024

After merging 7ace741 and d6201aa, we no longer need to deal with ADDITIONAL_OCI_ARTIFACT_TYPES.

Please, rebase your PR and make sure that
vnd.redhat.delta.manifest.v1+json (https://github.com/flatpak/flatpak-oci-specs/blob/main/image-deltas.md#locating-the-delta-manifest) is included in

MANIFEST_CHOICES = (
.

I wonder if we should add the media type to

"enum": [MEDIA_TYPE.MANIFEST_OCI],
and . It is worth to investigate this.

@ipanova
Copy link
Member

ipanova commented Mar 11, 2024

I doubt that vnd.redhat.delta.manifest.v1+json is being used despite what's written in docs. The documentation still references that this delta manifest is an OCI manifest(and it has predefined mediatypes).

@lubosmj
Copy link
Member

lubosmj commented Mar 12, 2024

https://github.com/flatpak/flatpak-oci-specs/pull/5/files being merged, I think we can safely close this PR and the corresponding issue because everything should work out of the box.

@MichalPysik, thanks for dedicating your efforts into this work. We appreciate your endeavor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user I want to distribute via registry flatpak delta manifests
3 participants