Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define Instance model #837

Merged
merged 4 commits into from
Nov 17, 2024
Merged

feat: define Instance model #837

merged 4 commits into from
Nov 17, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Nov 17, 2024

close #831

What does this PR do?

  • Instanceモデルの定義をしました
  • (クラスの)インスタンス生成チェックにスナップショットテストを導入しました

Additional information

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 67.45562% with 55 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (e8aa6ce) to head (ad408e1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/federation/model/instance.ts 58.33% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   49.13%   49.33%   +0.19%     
==========================================
  Files         165      167       +2     
  Lines       15435    15604     +169     
  Branches     1211     1221      +10     
==========================================
+ Hits         7584     7698     +114     
- Misses       7851     7906      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/federation/model/instance.ts Show resolved Hide resolved
pkg/federation/model/instance.ts Outdated Show resolved Hide resolved
pkg/federation/model/instance.ts Outdated Show resolved Hide resolved
pkg/federation/model/instance.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit f7a0df3 into main Nov 17, 2024
5 checks passed
@laminne laminne deleted the feat/831-define-instance-model branch November 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Instanceモデルの定義をする
2 participants