[v3] Remove __inputs in state #3772
Merged
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
danielrbradley
approved these changes
Dec 10, 2024
provider/pkg/version/version.go
Outdated
Comment on lines
10
to
12
| func GetVersion() semver.Version { | ||
| return semver.MustParse(Version) | ||
| } |
There was a problem hiding this comment.
Same as other PR .. this needs a default for unit tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3772 +/- ##
==========================================
- Coverage 56.65% 56.64% -0.02%
==========================================
Files 77 78 +1
Lines 11954 11969 +15
==========================================
+ Hits 6773 6780 +7
- Misses 4683 4689 +6
- Partials 498 500 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the next stage of removing the
__inputsfrom state. In this stage, the provider has "v2" and "v3" behavior. In "v2" mode, the behavior is unchanged. In "v3" mode,Configureasserts that the engine is passing the old inputs, and doesn't write__inputsto state. The fallback code that reads the__inputsfrom state is effectively inoperative in the "v3" mode.Added a line item to this ticket for the final phase which is to remove the "v2" code:
#3754
Closes #2686