Skip to content

Commit

Permalink
replaceOnChanges -> willReplaceOnChanges
Browse files Browse the repository at this point in the history
replaceOnChanges causes the generated sdks to apply an extra replaceOnChanges resource option.  However, the yaml language doesn't have a generated sdk, so it doesn't work properly there.

Instead, we now check for replacement in the provider Diff function and document this with `willReplaceOnChanges` which is only used for docs.
  • Loading branch information
nyobe committed Dec 9, 2024
1 parent b2c1f36 commit c2c0bdb
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 20 deletions.
8 changes: 4 additions & 4 deletions provider/cmd/pulumi-resource-pulumiservice/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,7 @@
"timestamp": {
"description": "The time at which the schedule should run, in ISO 8601 format. Eg: 2020-01-01T00:00:00Z. If you are supplying this, do not supply scheduleCron.",
"type": "string",
"replaceOnChanges": true
"willReplaceOnChanges": true
},
"pulumiOperation": {
"description": "Which operation to run.",
Expand Down Expand Up @@ -1293,7 +1293,7 @@
"timestamp": {
"description": "The time at which the schedule should run, in ISO 8601 format. Eg: 2020-01-01T00:00:00Z. If you are supplying this, do not supply scheduleCron.",
"type": "string",
"replaceOnChanges": true
"willReplaceOnChanges": true
},
"pulumiOperation": {
"description": "Which command to run.",
Expand Down Expand Up @@ -1391,7 +1391,7 @@
"timestamp": {
"description": "The time at which the schedule should run, in ISO 8601 format. Eg: 2020-01-01T00:00:00Z.",
"type": "string",
"replaceOnChanges": true
"willReplaceOnChanges": true
},
"deleteAfterDestroy": {
"description": "True if the stack and all associated history and settings should be deleted.",
Expand Down Expand Up @@ -1426,7 +1426,7 @@
"timestamp": {
"description": "The time at which the schedule should run, in ISO 8601 format. Eg: 2020-01-01T00:00:00Z.",
"type": "string",
"replaceOnChanges": true
"willReplaceOnChanges": true
},
"deleteAfterDestroy": {
"description": "True if the stack and all associated history and settings should be deleted.",
Expand Down
4 changes: 0 additions & 4 deletions sdk/go/pulumiservice/deploymentSchedule.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions sdk/go/pulumiservice/ttlSchedule.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions sdk/nodejs/deploymentSchedule.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions sdk/nodejs/ttlSchedule.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions sdk/python/pulumi_pulumiservice/deployment_schedule.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions sdk/python/pulumi_pulumiservice/ttl_schedule.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c2c0bdb

Please sign in to comment.