New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub tests for DeploymentSettings #126

Open

EvanBoyle opened this issue Apr 10, 2023 · 1 comment

Labels

kind/engineering

Contributor

EvanBoyle commented Apr 10, 2023

I think we might need a new GitHub org to install the app to and I also don't have access to this Pulumi org that is being used for the tests here (it's in staging). All to say, we should definitely add that test but there's some friction there.

EvanBoyle added the kind/engineering label

EvanBoyle assigned komalali

EvanBoyle mentioned this issue

Fix Panic from marshalling deployPullRequests instead of previewPullRequests #125

Merged

komalali removed their assignment

Contributor

IaroslavTitov commented Nov 21, 2024

This issue is blocked by not having a GH app installed in staging. @komalali, if you're a GH admin, could you install the app there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment