Fix Panic from marshalling deployPullRequests instead of previewPullRequests
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
I did really want to add a test for the GitHub case but it requires the GitHub app to be installed - I think we might need a new GitHub org to install the app to and I also don't have access to this Pulumi org that is being used for the tests here (it's in staging). All to say, we should definitely add that test but there's some friction there.
|
Ah, yes. We have seen these struggles with testing against the github app before. Opened #126 as a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #124
Should we add an examples test that covers github integration?