Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding secret support to webhooks #440

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Adding secret support to webhooks #440

merged 1 commit into from
Nov 14, 2024

Conversation

IaroslavTitov
Copy link
Contributor

@IaroslavTitov IaroslavTitov commented Nov 13, 2024 •
edited
Loading

Summary

  • Added logic to handle ciphertext + plaintext way to handle secret value, preventing drift on webhook secrets
  • Moved shared logic into secret_util file for further reuse

Testing

  • Updated integ tests to use secret value

Note: do NOT merge until ciphertext change rolls out to prod

@IaroslavTitov IaroslavTitov marked this pull request as ready for review November 13, 2024 18:26
@IaroslavTitov IaroslavTitov merged commit b62ee3d into main Nov 14, 2024
13 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/secret_webhook branch November 14, 2024 16:34
@IaroslavTitov IaroslavTitov mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyeh seanyeh seanyeh approved these changes

@nyobe nyobe Awaiting requested review from nyobe

@dschaller dschaller Awaiting requested review from dschaller

@komalali komalali Awaiting requested review from komalali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IaroslavTitov @seanyeh