Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip post-merge tests #454

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Don't skip post-merge tests #454

merged 1 commit into from
Dec 6, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 6, 2024

Merging isn't triggering the pre-release step because tests are getting skipped.

I think this is due to the test getting a workflow_call event instead of a repository_dispatch event. This broke when I consolidated the test workflow, and moving the conditional up should fix it.

@blampe blampe requested a review from IaroslavTitov December 6, 2024 17:17
Copy link

github-actions bot commented Dec 6, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@blampe blampe merged commit a5cd9a5 into main Dec 6, 2024
24 of 25 checks passed
@blampe blampe deleted the blampe/fix-test-skip branch December 6, 2024 17:36
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@8281b34). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #454   +/-   ##
=====================================
  Coverage        ?      0           
=====================================
  Files           ?      0           
  Lines           ?      0           
  Branches        ?      0           
=====================================
  Hits            ?      0           
  Misses          ?      0           
  Partials        ?      0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulumi-bot
Copy link

This PR has been shipped in release v0.27.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants