Handle code blocks in import section #2382
Conversation
|
Hi @andrzejressel - thank you for your pull request. I'm trying to run tests for you but I'm seeing a setup issue on our end for the tests. Additionally, all Terraform code will need to be translated to Pulumi code. We do not, as a rule, display Terraform code in these docs. This is an incredibly gnarly part of our codebase, so thank you so much for willing to get involved here! 💟 I'm happy to help and answer questions, you can also find me on the community Slack for Pulumi. |
guineveresaenger
force-pushed
the
feature/fix_code_in_imports
branch
from
cca2891
to
e020b07
Compare
|
I've rebased and we should be able to get some better test output here. |
andrzejressel
force-pushed
the
feature/fix_code_in_imports
branch
from
e020b07
to
4c336bd
Compare
|
Should be fine now |
|
I will take a look next week - thank you for your patience! |
| importString = fmt.Sprintf("%s %s", importString, p) | ||
| } | ||
| // Handle terraform blocks - pass them whole without changes | ||
| if trimmedSection == "```terraform" || trimmedSection == "```hcl" { |
There was a problem hiding this comment.
Please use https://github.com/pulumi/pulumi-terraform-bridge/blob/master/pkg/tfgen/docs.go#L2353 for this check - it contains the current known detection patterns for TF code. 🙏
| if strings.HasPrefix(trimmedSection, "```") { | ||
| initial := true | ||
| for { | ||
| section = subsection[i] |
There was a problem hiding this comment.
This line panics when running this code against pulumi-gcp.
|
/run-acceptance-tests |
Fix for pulumi/pulumi-docker#1201
I've tested it with docker provider and it seems to be working fine apart from this warning:
which removes example from ServiceConfig, but I think this it not related to this change.