Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --icc=false option for docker daemon #995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjvrielink
Copy link

This used to be possible in version 9.1.0 and older, but got lost in translation from .erb to .epp templates.

Fixes #989

Summary

Changes 5 templates to use unless instead of if for the --icc parameter

Additional Context

If a user wants to specify the --icc parameter, they always will want to use --icc=false, as the default is true.
By using if $icc in the template, it is impossible to set -icc=false.

Related Issues (if any)

See issue #989

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

This used to be possible in version 9.1.0 and older, but got lost in
translation from .erb to .epp templates.

Fixes puppetlabs#989
@bjvrielink bjvrielink requested a review from a team as a code owner September 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpossible to disable icc with 10.x version of this module
1 participant