Skip to content

Commit

Permalink
✨ Added port to project.pros: (#292)
Browse files Browse the repository at this point in the history
* Uninstall charset_normalizer

* added port option

* Update pros/cli/conductor.py

Co-authored-by: BennyBot <[email protected]>

* Update .github/workflows/main.yml

Co-authored-by: BennyBot <[email protected]>

* Update pros/cli/upload.py

* 🐛 Fix fat binary error in CI (#293)

* Update main.yml

* Try new version of python

* Maybe this will work?

* We try again

* Make the uninstall work

* Work

---------

Co-authored-by: Kunwar Sahni <[email protected]>

* Uninstall charset_normalizer

* added port option

* Update pros/cli/conductor.py

Co-authored-by: BennyBot <[email protected]>

* Update .github/workflows/main.yml

Co-authored-by: BennyBot <[email protected]>

* Update pros/cli/upload.py

---------

Co-authored-by: ayushuk <[email protected]>
Co-authored-by: Ayush Shukla <[email protected]>
Co-authored-by: BennyBot <[email protected]>
Co-authored-by: Kunwar Sahni <[email protected]>
Co-authored-by: Benjamin Davis <[email protected]>
  • Loading branch information
6 people authored Sep 29, 2023
1 parent da40202 commit 149562b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pros/cli/upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ def upload(path: Optional[str], project: Optional[c.Project], port: str, **kwarg

# apply upload_options as a template
options = dict(**project.upload_options)
if 'port' in options and port is None:
port = options.get('port', None)
if 'slot' in options and kwargs.get('slot', None) is None:
kwargs.pop('slot')
elif kwargs.get('slot', None) is None:
Expand Down

0 comments on commit 149562b

Please sign in to comment.