-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Move PROS 4 to early access #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CLI changes, we usually required you to test your changes with a test plan expected and actual outputs on the PR. Overall it looks good, good job.
Closes #295 |
Co-authored-by: BennyBot <[email protected]>
Only concern I have is the okapi Message (also We should move okapi out of being a default template) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the okapi error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, will test this out tomorrow I think we should be good to merge
pros/cli/conductor.py
Outdated
@@ -91,8 +91,8 @@ def fetch(query: c.BaseTemplate): | |||
help="Force apply the template, disregarding if the template is already installed.") | |||
@click.option('--remove-empty-dirs/--no-remove-empty-dirs', 'remove_empty_directories', is_flag=True, default=True, | |||
help='Remove empty directories when removing files') | |||
@click.option('--beta', is_flag=True, default=False, show_default=True, | |||
help='Allow applying beta templates') | |||
@click.option('--early-access/--no-early-access', '--early/--no-early', '-ea/-nea', 'early_access', '--beta/--no-beta', default=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo --disable-early-access
> --no-early-access
but open to more opinions
Some things after testing this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
Deprecate PROS v3.
Closes #295