-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨🚨 Add pre-commit and Pylint #301
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hold, will be merged after the 3.5.0 release
@mayankpatibandla Can you solve the conflicts in the meantime? |
Conflicts have been resolved |
Lets wait to merge this after 3.5.1 since we want to get that out quickly and then when everything is stable again we can merge this and start enforcing it. |
Summary:
Adds pre-commit to run some hooks that must pass before a commit is allowed. Some basic errors regarding whitespace and unused variables have been fixed. Also adds Pylint to GitHub actions.
Motivation:
The goal is to enforce a more consistent coding style and fix linting issues. Currently most errors have been disabled, but we will need to enable some of them later to comply to a chosen standard.
References (optional):
#300
Test Plan:
pip install pre-commit
if you don't already have it, and then runpre-commit install
in the project directory. Pre-commit hooks should now run automatically every time a new commit is made.pre-commit run --all-files
passes for all files in the project.