-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix _exit implementation #671
base: develop-pros-4
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ion098 did you test this already? |
No, I haven't been able to test this yet. |
@Rocky14683 This should be ready for hardware testing, can you rerun the pipeline? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ion098 using the test code you've given, it doesn't print "hi" to the terminal before exiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary:
Changes the
_exit
function to flush the serial buffer and indefinitely block.Motivation:
The
_exit
function is supposed to never return, but right now it does.Test Plan:
_exit
exits the code_exit
always flushes the serial bufferTest Code: