-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Use unity build #715
base: develop-pros-4
Are you sure you want to change the base?
🚧 Use unity build #715
Conversation
…late 🐛 use `pros` instead of `prosv5` in Makefile
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
would this be faster than just passing |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
They do different things, the point of this PR is to increase optimization by combining all the source files into one, thus increasing optimization (similar to LTO). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I can no find no real sources online claiming that your given reason for this change is effective compared to LTO. Why? |
LTO would be the ideal solution, but there are a bunch of linker errors that look nontrivial to fix (although the errors here make unity builds also seem less trivial than I was hoping). |
Yeah, if you're getting mismatches across linked files, then putting them all into one file won't make them less mismatched. |
@djava |
* move version information * update scripts and makefiles * add version.h to main.h * fix bugs on windows and linux * move version.h to pros folder * update header comments
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
58e23bf
to
5c6bc34
Compare
Summary:
Motivation:
References (optional):
Test Plan: