Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Use unity build #715

Draft
wants to merge 11 commits into
base: develop-pros-4
Choose a base branch
from

Conversation

ion098
Copy link
Contributor

@ion098 ion098 commented Nov 8, 2024

Summary:

Motivation:

References (optional):

Test Plan:

@Rocky14683 Rocky14683 changed the base branch from develop to develop-pros-4 November 8, 2024 19:30
@ion098 ion098 changed the title 🚧 Use amalgamation build 🚧 Use unity build Nov 8, 2024
@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SizzinSeal
Copy link
Contributor

would this be faster than just passing -jto make?

@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ion098
Copy link
Contributor Author

ion098 commented Nov 8, 2024

@SizzinSeal

would this be faster than just passing -jto make?

They do different things, the point of this PR is to increase optimization by combining all the source files into one, thus increasing optimization (similar to LTO).

@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@djava
Copy link
Contributor

djava commented Nov 8, 2024

I can no find no real sources online claiming that your given reason for this change is effective compared to LTO. Why?

@ion098
Copy link
Contributor Author

ion098 commented Nov 8, 2024

@djava

I can no find no real sources online claiming that your given reason for this change is effective compared to LTO. Why?

LTO would be the ideal solution, but there are a bunch of linker errors that look nontrivial to fix (although the errors here make unity builds also seem less trivial than I was hoping).

@djava
Copy link
Contributor

djava commented Nov 8, 2024

Yeah, if you're getting mismatches across linked files, then putting them all into one file won't make them less mismatched.

@ion098
Copy link
Contributor Author

ion098 commented Nov 8, 2024

@djava
The errors here vs from LTO are very different and (most likely) stem from different root causes.

Rocky14683 and others added 2 commits November 8, 2024 19:22
* move version information

* update scripts and makefiles

* add version.h to main.h

* fix bugs on windows and linux

* move version.h to pros folder

* update header comments
@Rocky14683
Copy link
Member

/azp run

Copy link

Pull request contains merge conflicts.

@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Rocky14683
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants