BUG: Skip annotation destination being NullObject in PdfWriter

py-pdf · Nov 23, 2024 · eca3431 · eca3431
1 parent a6dc19f
commit eca3431
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pypdf/_writer.py b/pypdf/_writer.py
@@ -3000,6 +3000,8 @@ def _insert_filtered_annotations(
                             outlist.append(self._add_object(anc))
             else:
                 d = cast("DictionaryObject", ano["/A"])["/D"]
+                if isinstance(d, NullObject):
+                    continue
                 if isinstance(d, str):
                     # it is a named dest
                     if str(d) in self.get_named_dest_root():

diff --git a/tests/test_writer.py b/tests/test_writer.py
@@ -2484,6 +2484,16 @@ def test_append_pdf_with_dest_without_page(caplog):
     assert len(writer.named_destinations) == 3
 
 
+@pytest.mark.enable_socket
+def test_destination_is_nullobject():
+    """Tests for #2958"""
+    url = "https://github.com/user-attachments/files/17822279/C0.00.-.COVER.SHEET.pdf"
+    name = "iss2958.pdf"
+    source_data = BytesIO(get_data_from_url(url, name=name))
+    writer = PdfWriter()
+    writer.append(source_data)
+
+
 def test_stream_not_closed():
     """Tests for #2905"""
     src = RESOURCE_ROOT / "pdflatex-outline.pdf"