Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Rename local annotation variables #2980

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Dec 3, 2024

Make the names of annotation variables more consistent and readable.

j-t-1 added 2 commits December 3, 2024 08:27
Make the names of annotation variables more consistent and readable.
Make the names of annotation variables more consistent and readable.
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (6f541d3) to head (abff9d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2980   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          52       52           
  Lines        8752     8752           
  Branches     1593     1593           
=======================================
  Hits         8434     8434           
  Misses        190      190           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

I personally do not really see the benefit of annot over anno. Why not using annotation directly?

j-t-1 added 6 commits December 3, 2024 12:18
Make the names of annotation variables more consistent and readable.
Make the names of annotation variables more consistent and readable.
Make the names of annotation variables more consistent and readable.
Make the names of annotation variables more consistent and readable.
Make the names of annotation variables more consistent and readable.
@stefan6419846 stefan6419846 merged commit e1d65dc into py-pdf:main Dec 3, 2024
16 checks passed
@j-t-1 j-t-1 deleted the annot branch December 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants