Fix CasADI path and disable IREE for MacOS #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratman
requested review from
martinjrobins,
Saransh-cpp,
agriyakhetarpal,
arjxn-py and
a team
as code owners
|
@agriyakhetarpal, @MarcBerliner Not perfect, but a step in the correct direction until I can finish #4487 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4528 +/- ##
========================================
Coverage 99.42% 99.42%
========================================
Files 299 299
Lines 22715 22717 +2
========================================
+ Hits 22584 22586 +2
Misses 131 131 ☔ View full report in Codecov by Sentry. |
kratman
force-pushed
the
fix/casadiPath
branch
from
0e9f521
to
77e581b
Compare
|
I will deal with the lychee issues later, since that is not connected to this PR. We have entirely too many links that break |
MarcBerliner
approved these changes
Oct 18, 2024
pkalbhor
pushed a commit
to pkalbhor/PyBaMM
that referenced
this pull request
Nov 15, 2024
* Add a path for CasADI * Disable IREE for MacOS * style: pre-commit fixes * Update changelog * Style * Attempting to fix link issues * Attempting to fix link issues * Fix formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fixes for the issues with CasADI and IREE.
Related #4524
Related #4521
Type of change
The CasADI fix should work for MacOS and Linux builds, but does not fix Windows issues.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: