-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: prepare for 2.13.2 #5299
docs: prepare for 2.13.2 #5299
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, again!
|
||
Bug fixes: | ||
|
||
* Make ``gil_safe_call_once_and_store`` thread-safe in free-threaded CPython. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move these to a new Modernizations:
section? — Calling these bugs isn't really fair (to ourselves).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to add a new section, and this one specifically is a bug fix. The one below (PyMutex) isn't really a bug fix, and is somewhat important, so I could put it under New Features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've had a "Changes" section in the past, so I moved several things to that section.
docs/changelog.rst
Outdated
* Make ``gil_safe_call_once_and_store`` thread-safe in free-threaded CPython. | ||
`#5246 <https://github.com/pybind/pybind11/pull/5246>`_ | ||
|
||
* Use ``PyMutex`` instead of ``std::mutex`` in the free-threaded build for internal locking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe swap like this?
... for internal locking in the free-threaded build.
* docs: prepare for 2.13.2 Signed-off-by: Henry Schreiner <[email protected]> * Update changelog.rst * Update changelog.rst --------- Signed-off-by: Henry Schreiner <[email protected]>
Preparing for 2.13.2.