Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prepare for 2.13.2 #5299

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

Preparing for 2.13.2.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii requested a review from rwgk August 13, 2024 00:09
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, again!


Bug fixes:

* Make ``gil_safe_call_once_and_store`` thread-safe in free-threaded CPython.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move these to a new Modernizations: section? — Calling these bugs isn't really fair (to ourselves).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add a new section, and this one specifically is a bug fix. The one below (PyMutex) isn't really a bug fix, and is somewhat important, so I could put it under New Features.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had a "Changes" section in the past, so I moved several things to that section.

* Make ``gil_safe_call_once_and_store`` thread-safe in free-threaded CPython.
`#5246 <https://github.com/pybind/pybind11/pull/5246>`_

* Use ``PyMutex`` instead of ``std::mutex`` in the free-threaded build for internal locking.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe swap like this?

... for internal locking in the free-threaded build.

@henryiii henryiii merged commit 40f2c78 into pybind:master Aug 13, 2024
78 checks passed
@henryiii henryiii deleted the henryiii/docs/2132 branch August 13, 2024 13:04
henryiii added a commit that referenced this pull request Aug 13, 2024
* docs: prepare for 2.13.2

Signed-off-by: Henry Schreiner <[email protected]>

* Update changelog.rst

* Update changelog.rst

---------

Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants