Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#282 Restructure examples/ directory #375

Closed

Conversation

arjxn-py
Copy link

@arjxn-py arjxn-py commented Jun 19, 2024

Description

This PR restructures the examples directory to provide a more organized and user-friendly entry point for users seeking specific functionality.

Issue reference

Fixes #282

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

@arjxn-py arjxn-py marked this pull request as draft June 19, 2024 09:10
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (f72a85e) to head (e71f16e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #375      +/-   ##
===========================================
- Coverage    97.47%   97.35%   -0.13%     
===========================================
  Files           42       42              
  Lines         2418     2418              
===========================================
- Hits          2357     2354       -3     
- Misses          61       64       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjxn-py arjxn-py marked this pull request as ready for review June 28, 2024 10:51
@arjxn-py
Copy link
Author

I think this is ready for an initial review, I've covered most of the notebooks and scripts in #282-comment, example tests might be failing right now which i'll work on to fix.
However there's one notebook that's repeating in Getting Started/ & Design Optimisation/ i.e. spm_electrode_design

@arjxn-py arjxn-py force-pushed the #282-restructure-example-directory branch from 56b95ba to edb2ca1 Compare June 30, 2024 12:56
@arjxn-py
Copy link
Author

arjxn-py commented Jul 1, 2024

Tests are also passing now.
cc: @NicolaCourtier @BradyPlanden

@NicolaCourtier
Copy link
Member

Hi @arjxn-py, thanks for sharing your progress on this issue! A few comments:

  • please consider whether to put scripts and notebooks together in the new folder structure or keep separate (currently the new folders are all stored within examples/notebooks which will make the scripts difficult to find)
  • let's merge and rename LG_M50_ECM/data into just LGM50_data
  • the new plotting_a_dataset.ipynb is more like what I was imagining for importing_a_pybamm_model (importing, running and plotting the result of a PyBaMM model)
  • just "plotting a dataset" would be like the start of LGM_50_identification

Thanks again, please let me know if any questions and request a review when you are ready.

@NicolaCourtier NicolaCourtier marked this pull request as draft November 22, 2024 09:54
@NicolaCourtier
Copy link
Member

This branch has become outdated - issue #282 on the restructuring of the examples directory has been resolved by #559.
Please open a new issue if you would like to improve the examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure examples directory
2 participants