Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new draft: Visiting Group in PyCon APAC 2023 #50

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 6, 2023

Types of changes

  • new draft

Description

draft for our PyCon APAC 2023 report

@Lee-W Lee-W requested a review from a team as a code owner October 6, 2023 09:08
Copy link
Member

@tai271828 tai271828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不確定要 review 什麼,這不就是 draft 嗎? XD

@Lee-W
Copy link
Member Author

Lee-W commented Oct 8, 2023

不確定要 review 什麼,這不就是 draft 嗎? XD

之前tag要review的那個merge了xD
是搬blogger legacy post的
我把這個先轉draft好了

@Lee-W Lee-W marked this pull request as draft October 8, 2023 08:51
@Lee-W Lee-W marked this pull request as ready for review October 30, 2023 01:29
Copy link
Contributor

@winniepopu winniepopu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@winniepopu winniepopu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I found that we need to modified the slug text to 2023, right?
2023-11-xx-visiting-group-in-pycon-jp-2019

@Lee-W Lee-W force-pushed the pycon-apac-2023-visiting-group-report branch from 28a12da to d71306b Compare October 30, 2023 02:24
@Lee-W
Copy link
Member Author

Lee-W commented Oct 30, 2023

@winniepopu Yep, you're right. thanks for reminding me. just updated. could you please take another look?

Copy link
Contributor

@winniepopu winniepopu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great now, you can merge it! Thanks!

@Lee-W Lee-W merged commit 9f947f2 into main Oct 30, 2023
1 check passed
@Lee-W Lee-W deleted the pycon-apac-2023-visiting-group-report branch October 30, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants