Changed Table[User] to use data_model=User #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 11 11
Lines 718 718
=======================================
Hits 675 675
Misses 43 43 ☔ View full report in Codecov by Sentry. |
|
thanks so much. |
auto-merge was automatically disabled
December 22, 2023 11:58
Head branch was pushed to by a user without write access
|
My initial idea was to update README only. I also added a sample directory with the same code as in README as an suggestion. Feel free to remove it it it is not according to your ideas. When I commit I get an lint error. I don't get this error in my environment. I don't understand why I get the error because I didn't change the code. I only changed the README file... |
…quired." This reverts commit a75b1e0.
|
Lint check doesn't pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in the the README sample code.
Changed Table[User] which is depreciated to use data_model=User instead.