Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GoToEvent link generation when value is None #224

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix GoToEvent link generation when value is None #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffbb486
Fix GoToEvent link generation when value is None
hramezani Feb 27, 2024
5048431
change implementation
hramezani Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/npm-fastui/src/components/display.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,12 @@ export function renderEvent(event: AnyEvent | undefined, data: DataModel): AnyEv
if (newEvent) {
if (newEvent.type === 'go-to' && newEvent.url) {
// for go-to events with a URL, substitute the row values into the url
const url = subKeys(newEvent.url, data)
let url: string | null = null
try {
url = subKeys(newEvent.url, data)
} catch (e) {
url = null
}
if (url === null) {
newEvent = undefined
} else {
Expand Down
Loading