Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display 0 on DisplayLookup #274

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix display 0 on DisplayLookup #274

merged 1 commit into from
Apr 19, 2024

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Apr 17, 2024 •
edited
Loading

This is the old view that shows - instead of 0.
image

By this change it will only shows - for undefined

@hramezani hramezani requested a review from samuelcolvin April 17, 2024 17:40
@hramezani hramezani changed the title Fix display '0' on 'DisplayLookup' Fix display 0 on DisplayLookup Apr 17, 2024
sydney-runkle
sydney-runkle approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sydney-runkle sydney-runkle merged commit d0779c7 into main Apr 19, 2024
14 checks passed
@sydney-runkle sydney-runkle deleted the fix-display-lookup branch April 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

@samuelcolvin samuelcolvin Awaiting requested review from samuelcolvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hramezani @sydney-runkle