Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: implement DisplayMarkdown #279

Merged
merged 1 commit into from
May 30, 2024
Merged

task: implement DisplayMarkdown #279

merged 1 commit into from
May 30, 2024

Conversation

rgimen3z
Copy link
Contributor

Also added an example to the Users table.
Addresses: #248

@codecov Codecov
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rgimen3z
Copy link
Contributor Author

cc: @sydney-runkle since I saw you organizing and merging PRs recently (thanks for spending some time focused on FastUI!)

@rgimen3z
Copy link
Contributor Author

cc: @sydney-runkle since I saw you organizing and merging PRs recently (thanks for spending some time focused on FastUI!)

@sydney-runkle any chance we can get this reviewed (and merged) sooner rather than later? Thanks

sydney-runkle
sydney-runkle approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgimen3z,

Awesome work here. Apologies for the delay in reviewing!

@sydney-runkle sydney-runkle merged commit c61f2f7 into pydantic:main May 30, 2024
16 checks passed
@sydney-runkle sydney-runkle mentioned this pull request May 30, 2024
Closed
@Dragon-GCS
Copy link

It appears that this issue has not been fully resolved. On the demo page, the 'Status' column is not being correctly rendered as Markdown.
image

@rgimen3z rgimen3z deleted the ruben/implement-DisplayMarkdown branch July 1, 2024 17:49
@rgimen3z
Copy link
Contributor Author

rgimen3z commented Jul 1, 2024

It appears that this issue has not been fully resolved. On the demo page, the 'Status' column is not being correctly rendered as Markdown. image

I believe this is because FastUI's front-end code hasn't been deployed in over 2 months? @sydney-runkle are there plans to deploy following some sort of cadence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgimen3z @Dragon-GCS @sydney-runkle