Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for computed_field in Table component. #321

Merged
merged 6 commits into from
May 28, 2024
Merged

Add support for computed_field in Table component. #321

merged 6 commits into from
May 28, 2024

Conversation

hasansezertasan
Copy link
Contributor

Fixes: #320

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@jimkring jimkring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me 👍

@jimkring
Copy link
Contributor

@sydney-runkle @samuelcolvin I've reviewed this PR, yet maybe one of you wants to take a quick look before merging. It's a pretty small/simple fix. Thanks!

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the awesome work here @hasansezertasan @jimkring!

@sydney-runkle sydney-runkle merged commit 7c921b0 into pydantic:main May 28, 2024
16 checks passed
@hasansezertasan hasansezertasan deleted the table/computed_fields branch May 28, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

computed_field properties not showing in tables
3 participants