-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --show-action command line argument #392
base: master
Are you sure you want to change the base?
Conversation
@schettino72 let me know if you have any feedback :) |
keep going 😄 |
I am confused about this. The reporter is not looping over actions. The def execute(self, stream):
...
task_stdout, task_stderr = stream._get_out_err(self.verbosity)
for action in self.actions:
action_return = action.execute(task_stdout, task_stderr)
... |
So we need to make Task.execute call the reporter for each |
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=========================================
Coverage ? 99.70%
=========================================
Files ? 65
Lines ? 8898
Branches ? 0
=========================================
Hits ? 8872
Misses ? 26
Partials ? 0
Continue to review full report at Codecov.
|
I am planning to add a |
I was only able to support |
Related to #390