Skip to content

Commit

Permalink
Revert "Allow user to skip validation of pyproject.toml via env var"
Browse files Browse the repository at this point in the history
This reverts commit 913d50a.
  • Loading branch information
abravalheri committed Nov 12, 2024
1 parent 8f5559c commit f6c9fdb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
13 changes: 0 additions & 13 deletions setuptools/config/pyprojecttoml.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,6 @@ def load_file(filepath: StrPath) -> dict:


def validate(config: dict, filepath: StrPath) -> bool:
skip = os.getenv("SETUPTOOLS_DANGEROUSLY_SKIP_PYPROJECT_VALIDATION", "false")
if skip.lower() == "true": # https://github.com/pypa/setuptools/issues/4459
SetuptoolsWarning.emit(
"Skipping the validation of `pyproject.toml`.",
"""
Please note that some setuptools functionalities rely on the validation of
`pyproject.toml` against misconfiguration to ensure proper operation.
By skipping the automatic checks, you taking responsibility for making sure
the file is valid. Otherwise unexpected behaviours may occur.
""",
)
return True

from . import _validate_pyproject as validator

trove_classifier = validator.FORMAT_FUNCTIONS.get("trove-classifier")
Expand Down
7 changes: 0 additions & 7 deletions setuptools/tests/config/test_pyprojecttoml.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
)
from setuptools.dist import Distribution
from setuptools.errors import OptionError
from setuptools.warnings import SetuptoolsWarning

import distutils.core

Expand Down Expand Up @@ -395,9 +394,3 @@ def test_warn_tools_typo(tmp_path):

with pytest.warns(_ToolsTypoInMetadata):
read_configuration(pyproject)


def test_warn_skipping_validation(monkeypatch):
monkeypatch.setenv("SETUPTOOLS_DANGEROUSLY_SKIP_PYPROJECT_VALIDATION", "true")
with pytest.warns(SetuptoolsWarning, match="Skipping the validation"):
assert validate({"completely-wrong": "data"}, "pyproject.toml") is True

0 comments on commit f6c9fdb

Please sign in to comment.