Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 643 (Dynamic field for core metadata) #4698

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion setuptools/_core_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from packaging.version import Version

from . import _normalization, _reqs
from ._static import is_static
from .warnings import SetuptoolsDeprecationWarning

from distutils.util import rfc822_escape
Expand All @@ -27,7 +28,7 @@
def get_metadata_version(self):
mv = getattr(self, 'metadata_version', None)
if mv is None:
mv = Version('2.1')
mv = Version('2.2')
self.metadata_version = mv
return mv

Expand Down Expand Up @@ -207,6 +208,10 @@ def write_field(key, value):
self._write_list(file, 'License-File', self.license_files or [])
_write_requirements(self, file)

for field, attr in _POSSIBLE_DYNAMIC_FIELDS.items():
if (val := getattr(self, attr, None)) and not is_static(val):
write_field('Dynamic', field)

long_description = self.get_long_description()
if long_description:
file.write("\n%s" % long_description)
Expand Down Expand Up @@ -284,3 +289,33 @@ def _distribution_fullname(name: str, version: str) -> str:
canonicalize_name(name).replace('-', '_'),
canonicalize_version(version, strip_trailing_zero=False),
)


_POSSIBLE_DYNAMIC_FIELDS = {
# Core Metadata Field x related Distribution attribute
"author": "author",
"author-email": "author_email",
"classifier": "classifiers",
"description": "long_description",
"description-content-type": "long_description_content_type",
"download-url": "download_url",
"home-page": "url",
"keywords": "keywords",
"license": "license",
# "license-file": "license_files", # XXX: does PEP 639 exempt Dynamic ??
"maintainer": "maintainer",
"maintainer-email": "maintainer_email",
"obsoletes": "obsoletes",
# "obsoletes-dist": "obsoletes_dist", # NOT USED
"platform": "platforms",
"project-url": "project_urls",
"provides": "provides",
# "provides-dist": "provides_dist", # NOT USED
"provides-extra": "extras_require",
"requires": "requires",
"requires-dist": "install_requires",
# "requires-external": "requires_external", # NOT USED
"requires-python": "python_requires",
"summary": "description",
# "supported-platform": "supported_platforms", # NOT USED
}
188 changes: 188 additions & 0 deletions setuptools/_static.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
from functools import wraps
from typing import Any, TypeVar

import packaging.specifiers

from .warnings import SetuptoolsDeprecationWarning


class Static:
"""
Wrapper for built-in object types that are allow setuptools to identify
static core metadata (in opposition to ``Dynamic``, as defined :pep:`643`).

The trick is to mark values with :class:`Static` when they come from
``pyproject.toml`` or ``setup.cfg``, so if any plugin overwrite the value
with a built-in, setuptools will be able to recognise the change.

We inherit from built-in classes, so that we don't need to change the existing
code base to deal with the new types.
We also should strive for immutability objects to avoid changes after the
initial parsing.
"""

_mutated_: bool = False # TODO: Remove after deprecation warning is solved


def _prevent_modification(target: type, method: str, copying: str) -> None:
"""
Because setuptools is very flexible we cannot fully prevent
plugins and user customisations from modifying static values that were
parsed from config files.
But we can attempt to block "in-place" mutations and identify when they
were done.
"""
fn = getattr(target, method, None)
if fn is None:
return

@wraps(fn)
def _replacement(self: Static, *args, **kwargs):
# TODO: After deprecation period raise NotImplementedError instead of warning
# which obviated the existence and checks of the `_mutated_` attribute.
self._mutated_ = True
SetuptoolsDeprecationWarning.emit(
"Direct modification of value will be disallowed",
f"""
In an effort to implement PEP 643, direct/in-place changes of static values
that come from configuration files are deprecated.
If you need to modify this value, please first create a copy with {copying}
and make sure conform to all relevant standards when overriding setuptools
functionality (https://packaging.python.org/en/latest/specifications/).
""",
due_date=(2025, 10, 10), # Initially introduced in 2024-09-06
)
return fn(self, *args, **kwargs)

_replacement.__doc__ = "" # otherwise doctest may fail.
setattr(target, method, _replacement)


class Str(str, Static):
pass


class Tuple(tuple, Static):
pass


class List(list, Static):
"""
:meta private:
>>> x = List([1, 2, 3])
>>> is_static(x)
True
>>> x += [0] # doctest: +IGNORE_EXCEPTION_DETAIL
Traceback (most recent call last):
SetuptoolsDeprecationWarning: Direct modification ...
>>> is_static(x) # no longer static after modification
False
>>> y = list(x)
>>> y.clear()
>>> y
[]
>>> y == x
False
>>> is_static(List(y))
True
"""


# Make `List` immutable-ish
# (certain places of setuptools/distutils issue a warn if we use tuple instead of list)
for _method in (
'__delitem__',
'__iadd__',
'__setitem__',
'append',
'clear',
'extend',
'insert',
'remove',
'reverse',
'pop',
):
_prevent_modification(List, _method, "`list(value)`")


class Dict(dict, Static):
"""
:meta private:
>>> x = Dict({'a': 1, 'b': 2})
>>> is_static(x)
True
>>> x['c'] = 0 # doctest: +IGNORE_EXCEPTION_DETAIL
Traceback (most recent call last):
SetuptoolsDeprecationWarning: Direct modification ...
>>> x._mutated_
True
>>> is_static(x) # no longer static after modification
False
>>> y = dict(x)
>>> y.popitem()
('b', 2)
>>> y == x
False
>>> is_static(Dict(y))
True
"""


# Make `Dict` immutable-ish (we cannot inherit from types.MappingProxyType):
for _method in (
'__delitem__',
'__ior__',
'__setitem__',
'clear',
'pop',
'popitem',
'setdefault',
'update',
):
_prevent_modification(Dict, _method, "`dict(value)`")


class SpecifierSet(packaging.specifiers.SpecifierSet, Static):
"""Not exactly a built-in type but useful for ``requires-python``"""


T = TypeVar("T")


def noop(value: T) -> T:
"""
>>> noop(42)
42
"""
return value


_CONVERSIONS = {str: Str, tuple: Tuple, list: List, dict: Dict}


def attempt_conversion(value: T) -> T:
"""
>>> is_static(attempt_conversion("hello"))
True
>>> is_static(object())
False
"""
return _CONVERSIONS.get(type(value), noop)(value) # type: ignore[call-overload]


def is_static(value: Any) -> bool:
Copy link
Contributor

@Avasam Avasam Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An object parameter should match anything. You should be able to avoid using Any here.

Suggested change
def is_static(value: Any) -> bool:
def is_static(value: object) -> bool:

You can also make this function a type-guard with:

Suggested change
def is_static(value: Any) -> bool:
if TYPE_CHECKING:
from typing_extensions import TypeGuard # Added to typing in Python 3.10
def is_static(value: object) -> TypeGuard[Static]:

"""
>>> is_static(a := Dict({'a': 1}))
True
>>> is_static(dict(a))
False
>>> is_static(b := List([1, 2, 3]))
True
>>> is_static(list(b))
False
"""
return isinstance(value, Static) and not value._mutated_


EMPTY_LIST = List()
EMPTY_DICT = Dict()
Loading
Loading