Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submodule #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Emre-Yorat89
Copy link
Contributor

@Emre-Yorat89 Emre-Yorat89 commented Oct 23, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to the main environment at PyPSA-Earth repository
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member

Great @Emre-Yorat89 :D
Many thanks for the contribution, unfortunately it seems there is still a problem with the CI.

The problem relies on the merge event that has lead to significant changes in pypsa-earth and the revision of the config implementation.
Now configs are incrementally changed starting from a default config file and then changes are added subsequently.

For example, if you look at config.tutorial.yaml, the content has significantly changed.

Updating the repo to the latest change is a bit more challenging, it may be easier to create a custom environment file instead.
Would you like to open a new PR where we add a folder "envs" and inside we place a new environment file that is the same as the one we currently use for pypsa-distribution:
https://github.com/pypsa-meets-earth/pypsa-earth/blob/c1d4b993dc52d1f22a46efab983bcef5289afb95/envs/environment.yaml

but we add:

@Margherita-Capitani has proposed also a similar solution :)

Contestually, it would be great to revise the installation guide of:

  • README.md: this shall revise the section of conda env create to link to the newly created file envs/environment.yaml
  • doc/installation.rst: similarly to above, it shall be revised accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants