Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model Energg Demand and Fix Problem of Submodels #55

Merged

Conversation

Margherita-Capitani
Copy link
Contributor

In this pull request, the following are proposed:

  • A new methodology for calculating energy demand by introducing the ramp tool
  • an update for the environment that should solve the problem of dependencies.

Updates have been tested locally and are working. Updating the environment requires recreating the environment locally.

@Emre-Yorat89
Copy link
Contributor

Hi Margherita, interesting test workflow error that I have shared below. It indicates an error for the fiona package. I have locally tested it by assigning an arbitrary path and run the same code. The code runs without the attribute error.

attributeerror_

@Margherita-Capitani
Copy link
Contributor Author

Hi Emre!!! Then locally by updating the environment things work, I thought the changes were enough to change the CI-Linux enviroment as well, but that was not the case!
Yesterday @davide-f showed me how to modify CI-Linux, today I will try the modification and see if it works!

Theoretically I think the problem may be on the version of the Fiona package, after the Pypsa-Earth updates.
I will try, hopefully :D

@Margherita-Capitani
Copy link
Contributor Author

@davide-f can you please check with this morning's change which environment is used by CI-Linux?

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments :) many thanks!
Indeed, the CI is not using the new env yet. With the proposed comment, it should work out

.github/workflows/ci-linux.yaml Outdated Show resolved Hide resolved
data/costs.csv Outdated Show resolved Hide resolved
scripts/add_electricity.py Outdated Show resolved Hide resolved
scripts/add_electricity.py Outdated Show resolved Hide resolved
scripts/cluster_buildings.py Outdated Show resolved Hide resolved
scripts/create_network.py Outdated Show resolved Hide resolved
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Margherita-Capitani :D
Merging

@davide-f davide-f marked this pull request as ready for review November 12, 2024 18:31
@davide-f davide-f merged commit d800196 into pypsa-meets-earth:main Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants