Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vmprof firefox converter blog #117

Merged
merged 10 commits into from
May 14, 2024

Conversation

Cskorpion
Copy link
Contributor

No description provided.

posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
posts/2024/05/vmprof-firefox.md Show resolved Hide resolved
posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
@Cskorpion
Copy link
Contributor Author

Thanks for the Review. Is there anything else I can improve?

@cfbolz
Copy link
Member

cfbolz commented May 13, 2024

@mattip would you maybe have time to give this a read too? if you don't have time I would just click merge 😊

Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some trivial suggestions, feel free to ignore and merge as-is.

posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
posts/2024/05/vmprof-firefox.md Outdated Show resolved Hide resolved
@mattip mattip merged commit 8a61bf9 into pypy:main May 14, 2024
4 checks passed
@mattip
Copy link
Member

mattip commented May 14, 2024

Thanks @Cskorpion, and thanks for the convertor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants