Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: refactor build infrastructure #1888

Closed
wants to merge 1 commit into from

Conversation

nstarman
Copy link
Contributor

This PR refactors the build infrastructure to

  1. remove the setup.py in favor of pyproject.toml
  2. dynamically generate the version from the pyproject (this is not a VCS dynamic versioning)
  3. be compatible with uv but still all other tools, like conda,
  4. use src folder layout.

@nstarman nstarman changed the title build: refactor build infrastruture build: refactor build infrastructure Oct 12, 2024
@nstarman nstarman force-pushed the switch-to-pyproject branch from bb0f244 to da88c27 Compare October 12, 2024 18:37
@fehiepsi
Copy link
Member

Hi @nstarman, thanks for the refactor. We would prefer to keep the current setup. I'm not sure why we need to be compatible with uv (shouldn't uv thing be compatible with the python ecosystem?) and why we need to use the src layout.

@nstarman
Copy link
Contributor Author

uv is compatible with the python ecosystem. It just adds config to pyproject.toml for development and adds a lockfile, which is useful.
Is there a reason for keeping the outdated setup.py?
When I've been doing dev in my last PR my editable build is producing a numpyro.egg-info in the top-level env. The src layout is better for isolating dev environments. Because of git-mv current PRs can rebase without consequence.

@fehiepsi
Copy link
Member

@nstarman
Copy link
Contributor Author

re setup.py: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#setup-py-deprecated

Yes, it's not deprecated. I was careful to use "outdated" as new standards have superseded setup.py, offering standardization, better integrations with developer tooling, safety from arbitrary code execution, improved reproducibility in builds, support for PEP 517/518, and longevity (version 21.3 of pip has started moving away from supporting editable installs via setup.py)

@fehiepsi
Copy link
Member

Thanks. Could you make a new PR just for setup.py changes?

@nstarman nstarman force-pushed the switch-to-pyproject branch from da88c27 to 5acf397 Compare October 16, 2024 22:35
@fehiepsi
Copy link
Member

fehiepsi commented Dec 5, 2024

Close, in favor of #1891

@fehiepsi fehiepsi closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants