Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SteinVI docs #1898

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Updated SteinVI docs #1898

merged 2 commits into from
Nov 5, 2024

Conversation

OlaRonning
Copy link
Member

Added ASVGD and SVGD to the SteinVI documentation.

@OlaRonning OlaRonning requested a review from fehiepsi November 4, 2024 14:09
@juanitorduz
Copy link
Contributor

Hi! I have thought about giving it a try to SteinVI, but I am unsure about the intuition of the kernel selection and maybe a rule of thumb for the number of particles and other parameters. I know there are some papers referenced, but it would be great to have some comments or tips around these practical details (of course not as part of this PR, but just a kind request if possible and easy to add sometime) :)

@OlaRonning
Copy link
Member Author

@juanitorduz I've added some recommendations regarding the number of particles, number of ELBO particles, optimizer and kernel in the class description for SteinVI. I figured that is what shows up in users IDE.

Can you write what you'd like recommendations for in an issue or on the forum? That way, I can look at it, and we don't pollute this PR :)

@juanitorduz
Copy link
Contributor

Thanks! Absolutely! I will do 🙇

@fehiepsi fehiepsi merged commit 569ea70 into pyro-ppl:master Nov 5, 2024
4 checks passed
@OlaRonning OlaRonning deleted the steinvi/docs branch November 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants