Proof of Concept: Types and MyPy #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanitorduz
commented
Nov 12, 2024
| @@ -278,7 +279,7 @@ def scan_wrapper( | |||
| length, | |||
| reverse, | |||
| rng_key=None, | |||
| substitute_stack=[], | |||
| substitute_stack=None, | |||
There was a problem hiding this comment.
This is something I spotted while adding hints. We would want to avoid having mutables as defaults.
juanitorduz
commented
Nov 12, 2024
| @@ -4,6 +4,7 @@ lint: FORCE | |||
| ruff check . | |||
| ruff format . --check | |||
| python scripts/update_headers.py --check | |||
| mypy --install-types --non-interactive numpyro | |||
There was a problem hiding this comment.
juanitorduz
commented
Nov 12, 2024
| ignore_missing_imports = true | ||
|
|
||
| [[tool.mypy.overrides]] | ||
| module = [ |
There was a problem hiding this comment.
Here, we can keep adding the modules we want to check. Eventually, we would like to simply remove this and check everything
|
LGTM! The changes are pretty clean to me. Do you want to submit this? |
fehiepsi
approved these changes
Nov 13, 2024
Yes, for me, we can merge, and I continue (bit by bit) adding hints (you can also advertise this task and maybe others can help as well, maybe even some of the ones that did it for Pyro ;) ) |
|
Thanks @juanitorduz! cc @ordabayevy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration in the journey to add type hints to the project #299 .
We can add types on small and modular iterations, and the community can help (so these can be labeled as good first issues). I found this nice blog https://breadcrumbscollector.tech/mypy-how-to-use-it-in-my-project/ that provides tips on how to add types gradually.
Let me you what you think about this proof-of-concept PR