Merge postprocess_fn into the fori_collect loop #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlaRonning
reviewed
Nov 20, 2024
| # We have two extra calls to the model to get deterministic values: | ||
| # 1. transform the init state | ||
| # 2. transform state during the loop | ||
| assert GLOBAL["count"] == 5 + num_traces_for_heuristic |
There was a problem hiding this comment.
Could you add an assertion that x_copy is in the get_samples? Perhaps test_mcmc.py would be a better place for the suggested test.
There was a problem hiding this comment.
yes, it is tested at
numpyro/test/infer/test_mcmc.py
Line 161 in 5c2eafa
OlaRonning
reviewed
Nov 20, 2024
| fields = [fields] if len(collect_fields) == 1 else list(fields) | ||
| site_values = jax.tree.flatten(fields[0])[0] | ||
| if len(site_values) > 0: | ||
| fields[0] = postprocess_fn(fields[0], *x[1:]) |
There was a problem hiding this comment.
Could you clarify what is stored in fields[1:] if len(collect_fields) >1 since we only need to run postprocess_fn on the first element?
There was a problem hiding this comment.
The first one is the sample field. The rest are extra fields.
There was a problem hiding this comment.
I see, then it makes sense that constraints are only applied to the first field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: current tests are passing