Support Python 3.9 #1923
Merged
Support Python 3.9 #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also add 3.12 and 3.13 to the setup file and add 3.13 to the lint check? (we can fix bug on those python versions in later release if users report) Thanks! |
|
@fehiepsi Do we want to extend the run the CI tests with Python 3.9 as well? |
|
yes, I think we can add tests for modeling and inference. I'm not sure how complicated it is to fix tests |
|
ok! 8346b55 tests work fine. However, there seems to be an issue installing dependencies with Python 3.13 👀 |
fehiepsi
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Awesome! thanks @juanitorduz!
Some dependencies in dev might not be compatible with python 3.13. That's fine for now I think. We can revisit in the future. Let me know if this is ready to merge.
|
Ok! In this case this first iteration is complete :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1922
The lint commit d32b54a failed as expected. The fix in https://github.com/pyro-ppl/numpyro/actions/runs/12120151093/job/33788225675?pr=1923 makes the Python 3.9 linter happy.